-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support data compression in Broadcast
/ Passthrough
exchange operator; optimize process about choosing Broadcast Join;
#41968
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Broadcast
/ Passthrough
exchange operator
/retest |
…ompress-bj-exchange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
ca6d4ed
to
959dce0
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c1495a9
|
/hold |
/hold |
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ab47aa
|
/unhold |
/test unit-test |
What problem does this PR solve?
Issue Number: ref #40494
What is changed and how it works?
Broadcast
/Passthrough
exchange operatortidb_prefer_broadcast_join_by_exchange_data_size
(release-7.1)tidb_broadcast_join_threshold_size
andtidb_broadcast_join_threshold_count
will be ignored if planner success to determine whether need broadcast.Benchmark
ENV
Original Threshold x 10
: only update threshold about broadcast joinQ8
optimized
Benchmark: One MPP Store
ENV
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.