Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: do not resolve locks frequently when log-backup task do not exist #40762

Merged

Conversation

joccau
Copy link
Member

@joccau joccau commented Jan 22, 2023

cherry-pick #40760

What problem does this PR solve?

Issue Number: ref #40759

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2023
@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/run-all-tests

@joccau joccau requested a review from 3pointer January 22, 2023 06:22
@joccau joccau changed the title log-backup: do not resolve locks frequently when log-backup task did … br: do not resolve locks frequently when log-backup task did … Jan 22, 2023
@joccau joccau changed the title br: do not resolve locks frequently when log-backup task did … br: do not resolve locks frequently when log-backup task do not exist Jan 22, 2023
@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/run-all-tests

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/run-build

@joccau joccau closed this Jan 22, 2023
@joccau joccau reopened this Jan 22, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 22, 2023
@wuhuizuo
Copy link
Contributor

/retest build

@ti-chi-bot
Copy link
Member

@wuhuizuo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/retest build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

/test build

1 similar comment
@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test build

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test cehck_dev

@ti-chi-bot
Copy link
Member

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test cehck_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test check_dev

@ti-chi-bot
Copy link
Member

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test check-dev

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test check-dev2

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test all-tests

@ti-chi-bot
Copy link
Member

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/test all

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 22, 2023
@joccau
Copy link
Member Author

joccau commented Jan 22, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5998413

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 22, 2023
@ti-chi-bot ti-chi-bot merged commit 5b2cee3 into pingcap:release-6.5-20230122-v6.5.0 Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants