Shenli/fix hibernate bug #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dataType := types.TypeToStr(col.Tp, col.Charset == charset.CharsetBin) | ||
| columnType := fmt.Sprintf("%s(%d)", dataType, colLen) | ||
| columnType := types.TypeToStr(col.Tp, col.Charset == charset.CharsetBin) | ||
| if col.Decimal == types.UnspecifiedLength { |
There was a problem hiding this comment.
I see other similar handing for type(m, n) in util/types and column, maybe we can unify them.
Btw, you can see that float and double don't have (m, n) even they have length and decimal.
There was a problem hiding this comment.
Yes.
And for data type without decimal, n will always be UnSpecifiedLength until the data is sent to mysql-client.
| ans := []string{ts} | ||
| // SimpleString only consider Tp/CharsetBin/Flen/Deimal. | ||
| // This is used for showing column type in infoschema. | ||
| func (ft *FieldType) SimpleString() string { |
…e-quotes Address comment and add testcase
| } | ||
|
|
||
| // GetDefaultDecimal returns the default decimal length for column. | ||
| func GetDefaultDecimal(tp byte) int { |
There was a problem hiding this comment.
How about GetDefaultFieldDecimal?
|
PTAL @siddontang |
| @@ -123,7 +123,7 @@ const defaultPrivileges string = "select,insert,update,references" | |||
| func (c *Col) GetTypeDesc() string { | |||
| var buf bytes.Buffer | |||
|
|
|||
| buf.WriteString(types.FieldTypeToStr(c.Tp, c.Charset)) | |||
| buf.WriteString(types.TypeToStr(c.Tp, c.Charset)) | |||
| switch c.Tp { | |||
YuJuncen
added a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* task, restore: send DDLs parallelly * restore: use moded id to index sessionpool * store: return nil DB when no TiDB session provided * *: use isolated DB instead of Session * *: fix some mis-pushed files :| * *: rename session pool to DB pool * restore: rename some sessions to dbs * restore: add some todos Co-authored-by: 3pointer <luancheng@pingcap.com>
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* optimize progress * update Co-authored-by: 3pointer <luancheng@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this bug:
create table t1 (c double);
create table t2 (c double);
insert into t1 value (73);
insert into t2 value (930);
select c from t1 union select c from t2;
+----+
| c |
+----+
| 73 |
| 0 |
+----+