Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix that the result of expression castRealAsTime is inconsistent with mysql #37461

Merged
merged 6 commits into from
Sep 2, 2022
Merged

expression: fix that the result of expression castRealAsTime is inconsistent with mysql #37461

merged 6 commits into from
Sep 2, 2022

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Aug 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37462

Problem Summary:
fix that the result of expression castRealAsTime is inconsistent with mysql

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix that the result of expression castRealAsTime is inconsistent with mysql.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2022
@mengxin9014 mengxin9014 changed the title WIP: expression: fix cast double as datetime inconsistent with mysql WIP: expression: fix that the result of expression castRealAsTime is inconsistent with mysql Aug 30, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 30, 2022
@mengxin9014
Copy link
Contributor Author

/run-check-issue-triage-complete

@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/de7fa853e088defe076c1148eed67a0be91e6458

@mengxin9014
Copy link
Contributor Author

/check-issue-triage-complete

@mengxin9014 mengxin9014 changed the title WIP: expression: fix that the result of expression castRealAsTime is inconsistent with mysql expression: fix that the result of expression castRealAsTime is inconsistent with mysql Aug 30, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@mengxin9014
Copy link
Contributor Author

/cc @XuHuaiyu @windtalker PTAL

@ti-chi-bot
Copy link
Member

@mengxin9014: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @XuHuaiyu @windtalker PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengxin9014
add tests
c4af102
@mengxin9014
Merge branch 'mx/fixCastDoubleAsDatetimeInconsistentWithMysql' of git…
4e02ca2 
…hub.com:mengxin9014/tidb into mx/fixCastDoubleAsDatetimeInconsistentWithMysql
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2022
windtalker
windtalker approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 105fd88

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2022
@ti-chi-bot ti-chi-bot merged commit 0482b2e into pingcap:master Sep 2, 2022
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-5.0
4a7c4cc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #37559

@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-5.1
e01420e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #37560

@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-5.2
e5a5b03 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #37561

@sre-bot
Copy link
Contributor

sre-bot commented Sep 2, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 14 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 57 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 21 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #37562

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-5.3
227f298 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-5.4
a362ade 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #37564

@ti-srebot ti-srebot mentioned this pull request Sep 2, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 2, 2022
@mengxin9014 @ti-srebot
cherry pick pingcap#37461 to release-6.1
882e3af 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #37567

@mengxin9014 mengxin9014 deleted the mx/fixCastDoubleAsDatetimeInconsistentWithMysql branch September 6, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of TiDB's expression CastRealAsTime() is inconsistent with Mysql.
7 participants
@mengxin9014 @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @windtalker @XuHuaiyu