Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table partition: add more warnings to inform the user that setting TiDB partition prune mode to dynamic at session level #35046

Merged
merged 8 commits into from
May 31, 2022
Merged

table partition: add more warnings to inform the user that setting TiDB partition prune mode to dynamic at session level #35046

merged 8 commits into from
May 31, 2022

Conversation

ymkzpx
Copy link
Contributor

@ymkzpx ymkzpx commented May 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35042

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test

Side effects

None.

Documentation

None.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None.

@ymkzpx ymkzpx requested a review from a team as a code owner May 30, 2022 13:19
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 30, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2beab6aef3118eb10104402a635cdcc70593347b

@ymkzpx
Copy link
Contributor Author

ymkzpx commented May 30, 2022

/cc @bb7133 @mjonss

@ti-chi-bot ti-chi-bot requested review from bb7133 and mjonss May 30, 2022 15:20
bb7133
bb7133 reviewed May 31, 2022
View reviewed changes
table/tables/partition_test.go Outdated Show resolved Hide resolved
table/tables/partition_test.go Show resolved Hide resolved
table/tables/partition_test.go Show resolved Hide resolved
ymkzpx and others added 4 commits May 31, 2022 10:36
@ymkzpx ymkzpx requested a review from bb7133 May 31, 2022 02:59
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
bb7133
bb7133 approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@bb7133
Copy link
Member

bb7133 commented May 31, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6baea4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@bb7133 bb7133 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 31, 2022
mjonss
mjonss approved these changes May 31, 2022
View reviewed changes
sessionctx/variable/sysvar.go
@@ -1406,6 +1406,7 @@ var defaultSysVars = []*SysVar{
newMode := strings.ToLower(strings.TrimSpace(val))
if PartitionPruneMode(s.PartitionPruneMode.Load()) == Static && PartitionPruneMode(newMode) == Dynamic {
s.StmtCtx.AppendWarning(errors.New("Please analyze all partition tables again for consistency between partition and global stats"))
s.StmtCtx.AppendWarning(errors.New("Please avoid setting partition prune mode to dynamic at session level and set partition prune mode to dynamic at global level"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still not clear why one should use global level in the warning. Maybe a link to documentation to explain the reason?

@bb7133
Copy link
Member

bb7133 commented May 31, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit e2fd394 into pingcap:master May 31, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 31, 2022
@ymkzpx @ti-srebot
cherry pick pingcap#35046 to release-6.1
407e842 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 31, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35079

@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 9 min 54 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 43 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request May 31, 2022
@ti-srebot
table partition: add more warnings to inform the user that setting Ti…
9e1be29 
…DB partition prune mode to dynamic at session level (#35046) (#35079)

close #35042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more warnings to inform the user that setting TiDB partition prune mode to dynamic at session level
7 participants
@ymkzpx @ti-chi-bot @sre-bot @bb7133 @ti-srebot @tiancaiamao @mjonss