*: use async get timestamp API && remove asyncGetTSWorker #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Jun 12, 2017
| go asyncGetTSWorker(s.store, s.txnFutureCh) | ||
| func (tf *txnFuture) wait() (kv.Transaction, error) { | ||
| startTS, err := tf.future.Wait() | ||
| if err == nil { |
There was a problem hiding this comment.
This error is always Canceled, caused by network timeout.
The real reason may be pd leader change or server down or network problem...
But it doesn't matter, if err not nil, we'll call store.Begin() in line 1070,
which would retry get timestamp until timeout.
zimulala
reviewed
Jun 12, 2017
| txnFuture := s.getTxnFuture() | ||
| goCtx, cancelFunc := goctx.WithCancel(goctx.Background()) | ||
| s.txnFuture, s.goCtx, s.cancelFunc = txnFuture, goCtx, cancelFunc | ||
| s.goCtx, s.cancelFunc = goctx.WithCancel(goctx.Background()) |
There was a problem hiding this comment.
Why store the Context inside a struct type?
There was a problem hiding this comment.
For historical reasons.
Each transaction goes along with a new context, transaction run in a session,
so the context is stored in the session.
|
LGTM |
|
LGTM |
shenli
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new GetTSAsync API, a session doesn't need to bind a
asyncGetTSWorkergoroutine any more.This change brings those benefits:
session.Closeis not called.