Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution: avoid decimal overflow and check valid #34399

Merged
merged 23 commits into from
Jun 17, 2022
Merged

execution: avoid decimal overflow and check valid #34399

merged 23 commits into from
Jun 17, 2022

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented May 5, 2022 •
edited
Loading

Signed-off-by: fzhedu fzhedu@gmail.com

What problem does this PR solve?

Issue Number: close #34388. close #30347

Problem Summary:

  1. avoid the flen/decimal overflow, so check the flen and decimal when set them for decimal;
  2. check the valid decimal when pushing down decimal, because TiFlash cannot solve invalid flen/decimal of decimal.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented May 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/15fe79f479c6e2e377c3aefc265223e3aac12987

@fzhedu fzhedu changed the title avoid decimal overflow for union all execution: avoid decimal overflow for union all May 6, 2022
@fzhedu
Copy link
Contributor Author

fzhedu commented May 6, 2022

/rebuild

1 similar comment
@fzhedu
Copy link
Contributor Author

fzhedu commented May 6, 2022

/rebuild

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2022
@fzhedu fzhedu changed the title execution: avoid decimal overflow for union all execution: avoid decimal overflow and check valid May 9, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2022
@fzhedu
Copy link
Contributor Author

fzhedu commented May 9, 2022

/rebuild

ti-chi-bot and others added 2 commits June 17, 2022 20:50
@ti-chi-bot
Merge branch 'master' into unionDecimal
41a9043
@fzhedu
fix tests
15fe79f 
Signed-off-by: fzhedu <fzhedu@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15fe79f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2022
@ti-chi-bot ti-chi-bot merged commit 9a77892 into pingcap:master Jun 17, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-5.0
0984700 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #35479

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-5.1
c96b118 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #35480

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-5.2
15da845 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #35481

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-5.3
80b9a4d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #35482

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-5.4
c5bb992 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35483

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-6.0
0e875b7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #35484

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2022
@fzhedu @ti-srebot
cherry pick pingcap#34399 to release-6.1
4f20c47 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35485

@sre-bot
Copy link
Contributor

sre-bot commented Jun 17, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 17 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 10 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 46 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 6 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 57 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@mengxin9014 mengxin9014 mentioned this pull request Oct 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
7 participants
@fzhedu @ti-chi-bot @sre-bot @ti-srebot @windtalker @guo-shaoge @XuHuaiyu