Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: support disabled status for binding #32819

Merged
merged 49 commits into from
Mar 16, 2022
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
113f3b4
bindinfo: rename Using status to Enable status
Reminiscent Mar 3, 2022
65da03b
convert the Using status binding to Enable status binding
Reminiscent Mar 3, 2022
c16dbf7
Merge branch 'master' of github.com:pingcap/tidb into bindingStatus
Reminiscent Mar 3, 2022
5ac35cd
address comments and fix ut
Reminiscent Mar 4, 2022
2a4f21e
Merge branch 'master' of github.com:pingcap/tidb into bindingStatus
Reminiscent Mar 4, 2022
7a49f34
fix ut
Reminiscent Mar 4, 2022
9fc6cff
bindinfo: support disable status for binding
Reminiscent Mar 4, 2022
52e91bf
fixup
Reminiscent Mar 4, 2022
7dff9d8
rename enable and disable to enabled and disabled
Reminiscent Mar 4, 2022
1b3a47e
Merge branch 'master' of github.com:pingcap/tidb into bindingStatus
Reminiscent Mar 4, 2022
722045d
remove useless change
Reminiscent Mar 4, 2022
dfbe5c6
change the parser part
Reminiscent Mar 4, 2022
adaf1cd
remove useless change
Reminiscent Mar 4, 2022
053bcf2
Merge branch 'master' of github.com:pingcap/tidb into bindingStatus
Reminiscent Mar 4, 2022
1e5008d
fix ut
Reminiscent Mar 4, 2022
3e8adb7
Merge branch 'master' of github.com:pingcap/tidb into bindingStatus
Reminiscent Mar 4, 2022
0a0fa6d
Merge branch 'master' into bindingStatus
ti-chi-bot Mar 7, 2022
164bcc1
Merge branch 'master' into bindingStatus
ti-chi-bot Mar 7, 2022
feb255c
Merge branches 'bindingStatus' and 'supportDisableStatus' of github.c…
Reminiscent Mar 8, 2022
a4b024b
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 8, 2022
df39a8f
rename
Reminiscent Mar 8, 2022
b6b2b11
fix typo
Reminiscent Mar 8, 2022
4134d63
remove useless change
Reminiscent Mar 8, 2022
a1e68c8
update the status from using to enabled when upgrade
Reminiscent Mar 8, 2022
479d86e
Merge branch 'master' into supportDisableStatus
qw4990 Mar 8, 2022
a514afb
Merge branch 'master' into supportDisableStatus
qw4990 Mar 8, 2022
8c45877
add more comments
Reminiscent Mar 9, 2022
6f6a355
Merge branch 'master' into supportDisableStatus
qw4990 Mar 9, 2022
6476661
planner: support 'set binding enabled/ disabled'
Reminiscent Mar 9, 2022
62aecaf
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 9, 2022
f58b8d1
Merge remote-tracking branch 'origin/supportDisableStatus' into suppo…
Reminiscent Mar 9, 2022
04069bf
format the header
Reminiscent Mar 9, 2022
d199115
fix check_dev
Reminiscent Mar 9, 2022
31f315c
Merge branch 'master' into supportDisableStatus
Reminiscent Mar 10, 2022
ae5dc5b
add more tests
Reminiscent Mar 15, 2022
fb12213
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 15, 2022
d80d763
Merge remote-tracking branch 'origin/supportDisableStatus' into suppo…
Reminiscent Mar 15, 2022
7c96a00
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 15, 2022
27272c9
update the warning message
Reminiscent Mar 15, 2022
b601865
add more test cases
Reminiscent Mar 15, 2022
f5b59a4
remove useless change
Reminiscent Mar 15, 2022
0c11684
Merge branch 'master' into supportDisableStatus
Reminiscent Mar 15, 2022
b196859
add the test for Privilege
Reminiscent Mar 16, 2022
ecf4d52
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 16, 2022
fe9e03e
Merge remote-tracking branch 'origin/supportDisableStatus' into suppo…
Reminiscent Mar 16, 2022
f09ec70
address comments
Reminiscent Mar 16, 2022
f7934c2
Merge branch 'master' of github.com:pingcap/tidb into supportDisableS…
Reminiscent Mar 16, 2022
c8f0977
address comments
Reminiscent Mar 16, 2022
e293107
Merge branch 'master' into supportDisableStatus
ti-chi-bot Mar 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove useless change
  • Loading branch information
Reminiscent committed Mar 8, 2022
commit 4134d63d2ba4634d3d7d3ea5872343aefa16176a
7 changes: 3 additions & 4 deletions bindinfo/bind_record.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,9 @@ func (br *BindRecord) size() float64 {
}

var statusIndex = map[string]int{
Enabled: 0,
deleted: 1,
Invalid: 2,
Disabled: 3,
Enabled: 0,
deleted: 1,
Invalid: 2,
}

func (br *BindRecord) metrics() ([]float64, []int) {
Expand Down