Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: don't decorrelate the APPLY when the inner's projection reference no column #32370

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

winoros
Copy link
Member

@winoros winoros commented Feb 15, 2022

…rences no column

What problem does this PR solve?

Issue Number: close #32089

Problem Summary:

When APPLY is left outer join and the inner child is projection without any reference to its child. We cannot decorrelate such APPLY for now. Since the evaluation of the constant expression would be different before and after the decorrelation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2022
@winoros winoros changed the title planner: don't decorrelate the APPLY when the inner's projection refe… planner: don't decorrelate the APPLY when the inner's projection reference no column Feb 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 15, 2022

winoros and others added 2 commits February 16, 2022 17:48
Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>
@winoros
Copy link
Member Author

winoros commented Feb 16, 2022

/run-unit-test

@winoros winoros requested a review from AilinKid February 16, 2022 18:15
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@qw4990
Copy link
Contributor

qw4990 commented Feb 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0e0d47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@ti-chi-bot ti-chi-bot merged commit 9911320 into pingcap:master Feb 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32571

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32572

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32573

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32574

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32575

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32576

@winoros winoros deleted the fix-issue32089 branch February 23, 2022 12:05
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong results with correlated subquery
7 participants