-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: remove the unnecessary offset
field in the key encoding for duplicate detection
#29975
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/component lightning |
a7fc9c8
to
0a4d848
Compare
0a4d848
to
3c32d05
Compare
/run-integration-br-test |
5ae3dbd
to
0987fc6
Compare
0987fc6
to
8928683
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
ce5ada4
to
12d58d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kennytm Could you please take a look? Thanks |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/12dcd01c88007d6dc7aca77da2bd021244621ed9 |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3fb2f2e
|
@gozssky: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Part of #29588.
Split from #30203.
Problem Summary:
The
rowID
that allocated by lightning is guaranteed to be unique, so we can remove the unnecessaryoffset
field in the key encoding for duplicate detection.What is changed and how it works?
Remove the unnecessary
offset
field in the key encoding for duplicate detection.I tested about 5 million rows for TPCC's order_line schema.
duplicate-resolution="none"
duplicate-resolution="record"
(master)duplicate-resolution="record"
(this PR)The results show that the write amplification of the index engine and data engine is significantly reduced.
Check List
Tests
Side effects
Documentation
Release note