-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add more daily benchmark test cases #26773
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ref #25754 |
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, maybe github.com/pingcap/tidb/benchkit
, just like the new testkit
? I think there are too many packages in the util, and nobody really cares except the author.
Co-authored-by: tangenta <tangenta@126.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 167659c
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
There are some
bench_test.go
files in different directories, and aTestBenchDaily
function.The
bench-daily
rule in the Makefile will run testTestBenchDaily
function and generate the json file,and then those json file are combined to generate the finally json file.
Check List
Tests
make daily-bench TO=xxx.json
Side effects
Documentation
Release note