Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: uncomment pushdown for JSONUnquote expression #24504

Merged
merged 5 commits into from
Jun 21, 2021
Merged

expression: uncomment pushdown for JSONUnquote expression #24504

merged 5 commits into from
Jun 21, 2021

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented May 9, 2021

What problem does this PR solve?

Issue Number: close #24415

Problem Summary:

What is changed and how it works?

This PR tries to open the pushdown of JSONUnquote expression, by uncommenting it in the 'pushdown list'.

Related changes

Check List

Tests

Release note

  • Enable the pushdown of builtin function json_unquote() to TiKV.

@bb7133 bb7133 requested a review from a team as a code owner May 9, 2021 09:49
@bb7133 bb7133 requested review from wshwsh12 and removed request for a team May 9, 2021 09:49
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 9, 2021
@bb7133
Copy link
Member Author

bb7133 commented May 9, 2021

/run-all-tests

@bb7133 bb7133 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2021
@kolbe
Copy link
Contributor

kolbe commented May 10, 2021

Presumably there's some reason this was forbidden at some point, some kind of compatibility issue that caused problems?

@wshwsh12
Copy link
Contributor

/run-integration-copr-test

@wshwsh12 wshwsh12 removed their request for review June 4, 2021 07:38
@guo-shaoge
Copy link
Collaborator

/run-all-tests

@guo-shaoge
Copy link
Collaborator

/run-common-test

@guo-shaoge
Copy link
Collaborator

/run-integration-common-test

@guo-shaoge
Copy link
Collaborator

Looks like we should update tidbtest first to make the case pass.

@breezewish
Copy link
Member

/run-integration-copr-test copr-test=pr/141

3 similar comments
@breezewish
Copy link
Member

/run-integration-copr-test copr-test=pr/141

@purelind
Copy link
Contributor

/run-integration-copr-test copr-test=pr/141

@purelind
Copy link
Contributor

/run-integration-copr-test copr-test=pr/141

@guo-shaoge
Copy link
Collaborator

/run-common-test tidb-test=pr/1221
/run-integration-common-test tidb-test=pr/1221
/run-integration-copr-test tidb-test=pr/1221

@guo-shaoge
Copy link
Collaborator

/run-all-tests tidb-test=pr/1221

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@guo-shaoge
Copy link
Collaborator

/run-common-test tidb-test=pr/1221
/run-integration-common-test tidb-test=pr/1221
/run-integration-copr-test tidb-test=pr/1221

@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66a1055

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@guo-shaoge guo-shaoge removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2021
@Rustin170506
Copy link
Member

/run-common-test tidb-test=pr/1221
/run-integration-common-test tidb-test=pr/1221
/run-integration-copr-test tidb-test=pr/1221

@Rustin170506
Copy link
Member

/run-common-test tidb-test=pr/1221

@guo-shaoge
Copy link
Collaborator

/run-all-tests

@guo-shaoge
Copy link
Collaborator

/run-common-test tidb-test=pr/1222
/run-integration-common-test tidb-test=pr/1222

@ti-chi-bot ti-chi-bot merged commit bd8d3b1 into pingcap:master Jun 21, 2021
@guo-shaoge
Copy link
Collaborator

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@bb7133 @ti-srebot
cherry pick pingcap#24504 to release-5.0
c4d3fbd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25720

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@bb7133 @ti-srebot
cherry pick pingcap#24504 to release-4.0
95a0650 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #25721

ti-chi-bot pushed a commit that referenced this pull request Jun 25, 2021
@ti-srebot
expression: uncomment pushdown for JSONUnquote expression (#24504) (#…
91a0139 
…25720)
ti-chi-bot pushed a commit that referenced this pull request Jul 8, 2021
@ti-srebot
expression: uncomment pushdown for JSONUnquote expression (#24504) (#…
6f46f2d 
…25721)
@guo-shaoge
Copy link
Collaborator

/label needs-cherry-pick-5.1

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 15, 2021
@bb7133 @ti-srebot
cherry pick pingcap#24504 to release-5.1
9991695 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26265

ti-chi-bot pushed a commit that referenced this pull request Jul 16, 2021
@ti-srebot
expression: uncomment pushdown for JSONUnquote expression (#24504) (#…
7a4c020 
…26265)
@bb7133 bb7133 deleted the bb7133/unquote_pushdown branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable pushdown for json_unquote
9 participants
@bb7133 @kolbe @wshwsh12 @guo-shaoge @breezewish @purelind @ti-chi-bot @Rustin170506 @ti-srebot