Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix a statistics GC problem that can cause duplicated fm-sketch records (#23830) #24357

Merged
merged 7 commits into from
May 10, 2021
Merged

statistics: fix a statistics GC problem that can cause duplicated fm-sketch records (#23830) #24357

merged 7 commits into from
May 10, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 28, 2021 •
edited
Loading

cherry-pick #23830 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24357

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24357:release-5.0-c637388e3f51

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: statistics: fix a statistics GC problem that can cause duplicated fm-sketch records

What is changed and how it works?

statistics: fix a statistics GC problem that can cause duplicated fm-sketch records

Check List

Tests

  • Unit test

Release note

  • statistics: fix a statistics GC problem that can cause duplicated fm-sketch records

@qw4990 @ti-srebot
cherry pick pingcap#23830 to release-5.0
895cefa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner April 28, 2021 11:56
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team April 28, 2021 11:56
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Apr 28, 2021
Merged
@ti-srebot ti-srebot added component/statistics sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 28, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 28, 2021
@ti-srebot
Copy link
Contributor Author

@qw4990 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2021
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@tangenta: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta tangenta added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 28, 2021
@rebelice
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 29, 2021

/merge

@winoros
Copy link
Member

winoros commented Apr 30, 2021

/run-check_dev
/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Apr 30, 2021

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented May 7, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented May 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2096e68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2021
@wshwsh12
Copy link
Contributor

wshwsh12 commented May 7, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@wshwsh12: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented May 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08c9cee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented May 10, 2021

/merge

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 10, 2021
@winoros
Copy link
Member

winoros commented May 10, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 1f4105e into pingcap:release-5.0 May 10, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.1, v5.0.2 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@rebelice rebelice Awaiting requested review from rebelice

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees

@qw4990 qw4990

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/statistics priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @tangenta @ti-chi-bot @rebelice @qw4990 @winoros @wshwsh12 @zhouqiang-cl