Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong flen infer for bit constant #23867

Merged
merged 4 commits into from
Apr 25, 2021
Merged

expression: fix wrong flen infer for bit constant #23867

merged 4 commits into from
Apr 25, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #23479

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix wrong flen infer for bit constant

@lzmhhh123
expression: fix wrong flen infer for bit constant
fb8ba70 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner April 6, 2021 09:36
@lzmhhh123 lzmhhh123 requested review from qw4990 and removed request for a team April 6, 2021 09:36
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 6, 2021
@lzmhhh123
Copy link
Contributor Author

/cc @XuHuaiyu @ichn-hu

@ichn-hu ichn-hu mentioned this pull request Apr 6, 2021
Closed
XuHuaiyu
XuHuaiyu reviewed Apr 7, 2021
View reviewed changes
types/field_type.go
@@ -250,7 +250,7 @@ func DefaultTypeForValue(value interface{}, tp *FieldType, char string, collate
SetBinChsClnFlag(tp)
case BitLiteral:
tp.Tp = mysql.TypeVarString
tp.Flen = len(x)
tp.Flen = len(x) * 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the max bit value for a byte is 127 which flen is 3

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@wshwsh12 wshwsh12 requested a review from XuHuaiyu April 16, 2021 06:32
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2021
@lzmhhh123
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2021
@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@Rustin170506
Copy link
Member

/merge cancel

for consistent failures.

@lzmhhh123 Could you please take a look?

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2021
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a54dd3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@ti-chi-bot ti-chi-bot merged commit 2c67a80 into pingcap:master Apr 25, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 25, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23867 to release-4.0
aca610b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #24266

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 25, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23867 to release-5.0
2d6dac5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 25, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24267

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_bit_div_int branch April 25, 2021 08:26
ti-chi-bot pushed a commit that referenced this pull request May 11, 2021
@ti-srebot
expression: fix wrong flen infer for bit constant (#23867) (#24266)
1d039ef
ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
expression: fix wrong flen infer for bit constant (#23867) (#24267)
899c2f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the behavior of bit type for / is incompatible with MySQL
7 participants
@lzmhhh123 @ti-chi-bot @Rustin170506 @ti-srebot @XuHuaiyu @wshwsh12 @ichn-hu