Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: add transaction usage info #23470

Merged
merged 7 commits into from
Mar 24, 2021
Merged

telemetry: add transaction usage info #23470

merged 7 commits into from
Mar 24, 2021

Conversation

youjiali1995
Copy link
Contributor

@youjiali1995 youjiali1995 commented Mar 23, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Telemetry reports the usage info of transaction-related features, including async-commit, 1PC and counters of transactions committed with different protocols.

What is changed and how it works?

What's Changed:

Read values of global sysvars and transaction commit metrics. Based on #23454

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • No release note.

@youjiali1995
telemetry: add transaction usage info
1f74dd8 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995
Merge branch 'master' of https://github.com/pingcap/tidb into metrics…
63e69f1 
…-for-txn-commit

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 23, 2021
@youjiali1995
Copy link
Contributor Author

/run-all-tests

@youjiali1995
remove unused codes
353b475 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995
Merge branch 'master' of https://github.com/pingcap/tidb into metrics…
6086f82 
…-for-txn-commit
@youjiali1995 youjiali1995 marked this pull request as ready for review March 23, 2021 13:31
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2021
@youjiali1995
Copy link
Contributor Author

/run-all-tests

@breezewish breezewish mentioned this pull request Mar 23, 2021
Merged
@youjiali1995
merge master
300f885 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 force-pushed the metrics-for-txn-commit branch from 731ac88 to 300f885 Compare March 24, 2021 01:45
@youjiali1995 youjiali1995 added the sig/execution SIG execution label Mar 24, 2021
youjiali1995
youjiali1995 commented Mar 24, 2021
View reviewed changes
telemetry/data.go Outdated Show resolved Hide resolved
lzmhhh123
lzmhhh123 reviewed Mar 24, 2021
View reviewed changes
telemetry/data.go Outdated Show resolved Hide resolved
@youjiali1995
only reset data after reporting telemetry data
250fbaf 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@youjiali1995
Copy link
Contributor Author

@breeswish PTAL

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2021
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@breeswish: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@youjiali1995
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 250fbaf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2021
@lzmhhh123
Copy link
Contributor

/merge

@youjiali1995
Copy link
Contributor Author

/run-unit-test

1 similar comment
@youjiali1995
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 906828b into pingcap:master Mar 24, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2021
@youjiali1995 @ti-srebot
cherry pick pingcap#23470 to release-5.0
b2aaaed 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 24, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23500

SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@youjiali1995 @SabaPing
telemetry: add transaction usage info (pingcap#23470)
b98dc88
breezewish pushed a commit to ti-srebot/tidb that referenced this pull request Mar 25, 2021
@youjiali1995 @breezewish
telemetry: add transaction usage info (pingcap#23470)
2460d3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@youjiali1995 @ti-chi-bot @breezewish @lzmhhh123 @ti-srebot