session, util: update session to use new APIs (#22652) #22805
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
requested review from
AilinKid,
bb7133,
tiancaiamao,
winoros and
xhebox
|
@morgo please accept the invitation then you can push to the cherry-pick pull requests. |
|
This is blocked by #22687 |
ti-chi-bot
added
the
size/L
morgo
force-pushed
the
release-5.0-rc-99d0b22f04fe
branch
from
15a840f
to
612871d
Compare
session/bootstrap.go
Outdated
| if err != nil { | ||
| return "", true, errors.Trace(err) | ||
| } | ||
| if len(rs) != 1 { | ||
| if rs == nil { |
There was a problem hiding this comment.
This check is not needed anymore. Check link.
|
/LGTM |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
@xhebox: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 32279de
|
ti-chi-bot
added
the
status/can-merge
|
@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #22652 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22805After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Part of https://github.com/pingcap/tidb-test/issues/1152
Problem Summary:
This fixes the session package to use the new APIs. It is expected to be backward compatible and covered by existing tests.
The bootstrap tasks between versions were not updated, as I'm not sure they will be accurately covered by unit tests to detect regressions.
What is changed and how it works?
New API usage.
Related changes
Check List
Tests
Side effects
Release note