table: fix insert into _tidb_rowid panic and rebase it if needed (#22062) #22359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@tangenta you're already a collaborator in bot's repo. |
|
/run-all-tests |
|
/run-all-tests |
ti-srebot
added
status/LGT2
bb7133
approved these changes
Jan 25, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22062 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr 22359After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22029
Problem Summary:
INSERTstatement,_tidb_rowidis assumed to be the last column in select fields. This is incorrect._tidb_rowiddoes not rebase after explicit insertion.What is changed and how it works?
What's Changed: Omitted.
How it Works: Omitted.
Related changes
Check List
Tests
Side effects
N/A
Release note
tidb_rowid.