Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix LEAD and LAG's default value can not adapt to field type (#20747) #21665

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20747 to release-4.0


What problem does this PR solve?

Issue Number: close #11755

Problem Summary: fix LEAD and LAG's default value can not adapt to field type

What is changed and how it works?

convert LEAD/LAG default value to field type

Check List

Tests

  • Integration test

Release note

  • fix LEAD and LAG's default value can not adapt to field type

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot you're already a collaborator in bot's repo.

@SunRunAway
Copy link
Contributor

/run-all-tests

@SunRunAway SunRunAway removed their request for review December 11, 2020 07:24
@SunRunAway SunRunAway assigned SunRunAway and unassigned ti-srebot Dec 11, 2020
ichn-hu
ichn-hu previously approved these changes Dec 15, 2020
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2020
@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
zz-jason
zz-jason previously approved these changes Jan 25, 2021
@ti-srebot ti-srebot removed the status/LGT2 Indicates that a PR has LGTM 2. label Jan 25, 2021
@ti-srebot ti-srebot added the status/LGT3 The PR has already had 3 LGTM. label Jan 25, 2021
@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21323
  • 21329
  • 21404
  • 21443
  • 21473
  • 21477
  • 21582
  • 21593
  • 21602
  • 21604
  • 21610
  • 21623
  • 21635
  • 21958
  • 22116
  • 22148
  • 22353
  • 21488
  • 21546
  • 21573
  • 21608

@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 22481
  • 21971

@qw4990 qw4990 dismissed stale reviews from zz-jason and ichn-hu via 3c5e309 January 26, 2021 12:20
@ti-srebot ti-srebot added status/LGT4 The PR has already had 4 LGTM. and removed status/LGT3 The PR has already had 3 LGTM. labels Jan 26, 2021
@qw4990 qw4990 merged commit ff32a24 into pingcap:release-4.0 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT4 The PR has already had 4 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants