expression: change the round rule for approximate value to round to nearest even (#21324)
#21628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
first-time-contributor
|
@wshwsh12 you're already a collaborator in bot's repo. |
ti-srebot
added
status/LGT2
ti-srebot
added
status/LGT3
|
/merge |
|
Sorry @qw4990, this branch cannot be merged without an approval of release maintainers. |
qw4990
approved these changes
Jan 26, 2021
ti-srebot
added
status/LGT4
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21324 to release-4.0
What problem does this PR solve?
Issue Number: close #1108
Problem Summary:
The Round rule for approximate-value numbers is “round half away from zero”, which is different from the “round to nearest even” rule used by MySQL.
What is changed and how it works?
What's Changed:
The round rule for approximate-value numbers is changed to “round to nearest even” rule.
How it Works:
select cast(25E-1 as signed)
+-----------------------+
| cast(25E-1 as signed) |
+-----------------------+
| 2 |
+-----------------------+
Related changes
Tests
Side effects
Release note