Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: set dbName for hinted query block table alias (#21213) #21380

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21213 to release-4.0


What problem does this PR solve?

Issue Number: close #15972

Problem Summary:

Hint does not take effect for query block table alias.

What is changed and how it works?

What's Changed:

RC for the ineffective hint is query block table alias has empty dbName, which is different with the specified hint. Set the dbName as CurrentDB if it is empty.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Set dbName for hinted query block table alias

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka
Copy link
Contributor

/run-unit-test

@jebter jebter modified the milestones: v4.0.9, v4.0.10 Nov 30, 2020
@eurekaka
Copy link
Contributor

/run-unit-test

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2020
@eurekaka
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

@eurekaka Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1

@eurekaka
Copy link
Contributor

/run-all-tests

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2020
@eurekaka eurekaka merged commit 7800681 into pingcap:release-4.0 Dec 23, 2020
@eurekaka eurekaka deleted the release-4.0-3e073c8a0878 branch December 23, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/sql-plan-management sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants