Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: fix inaccurate statistics of TIDB_HOT_REGIONS (#21278) #21319

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21278 to release-3.0


What problem does this PR solve?

Issue Number: close #21260

What is changed and how it works?

What's Changed: The same as #21269 but add the unit test.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • Fix the statistics are inaccurate when querying INFORMATION_SCHEMA.TIDB_HOT_REGIONS

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@rleungx please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

@rleungx rleungx force-pushed the release-3.0-183f2f3f97e4 branch 2 times, most recently from 839ba17 to 74da57b Compare December 10, 2020 09:43
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member

rleungx commented Dec 11, 2020

@crazycs520 @HunDunDM PTAL

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 11, 2020
@rleungx
Copy link
Member

rleungx commented Dec 11, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @rleungx, this branch cannot be merged without an approval of release maintainers.

@crazycs520 crazycs520 added the sig/sql-infra SIG: SQL Infra label Dec 11, 2020
@crazycs520
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @crazycs520, this branch cannot be merged without an approval of release maintainers.

@bb7133
Copy link
Member

bb7133 commented Dec 11, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @bb7133, this branch cannot be merged without an approval of release maintainers.

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 11, 2020
@bb7133
Copy link
Member

bb7133 commented Dec 11, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 11, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit dbe814c into pingcap:release-3.0 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants