expression, executor: allow insert strings with overflowed trailing spaces (#20987) #21282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
rewarded
sig/execution
|
@ichn-hu you're already a collaborator in bot's repo. |
|
/run-all-tests |
ti-srebot
added
status/LGT2
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20987 to release-4.0
What problem does this PR solve?
Issue Number: close #10392
Problem Summary:
For now, TiDB will complain with error if string inserted are longer than
varcharorchar's lenght constraint with trailing spaces, however, as in MySQL's dochttps://dev.mysql.com/doc/refman/8.0/en/char.html
What is changed and how it works?
Make overflowed trailing spaces trimed, and report warning for
varchar.Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note