Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: compare expression in check partition definition according to column type (#21226) #21273

Merged
merged 6 commits into from
Nov 25, 2020
Merged

ddl: compare expression in check partition definition according to column type (#21226) #21273

merged 6 commits into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21226 to release-4.0

What problem does this PR solve?

Issue Number: close #21227
close #21225

Problem Summary:

it is a patch of #20937, we cannot compare datetime, date, time type column as string type

Check List

Tests

  • Unit test

Release note

  • fix a bug that checks partition definition according to column type

@xiongjiwei @ti-srebot
cherry pick pingcap#21226 to release-4.0
d448b9b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Nov 25, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

@xiongjiwei you're already a collaborator in bot's repo.

@xiongjiwei
Copy link
Contributor

@tiancaiamao @crazycs520 PTAL

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
crazycs520
crazycs520 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @tiancaiamao, this branch cannot be merged without an approval of release maintainers

@bb7133
Copy link
Member

bb7133 commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @bb7133, this branch cannot be merged without an approval of release maintainers

@ti-srebot
Copy link
Contributor Author

@SunRunAway, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack).

@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @SunRunAway, this branch cannot be merged without an approval of release maintainers

@bb7133
Copy link
Member

bb7133 commented Nov 25, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @bb7133, this branch cannot be merged without an approval of release maintainers

@Hexilee
Copy link
Contributor

Hexilee commented Nov 25, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20889

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21171
  • 21146
  • 21238
  • 21283
  • 21079

@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit af8e479 into pingcap:release-4.0 Nov 25, 2020
@SunRunAway SunRunAway deleted the release-4.0-f4e58eecab8b branch November 26, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees

@xiongjiwei xiongjiwei

Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @xiongjiwei @tiancaiamao @bb7133 @SunRunAway @Hexilee @crazycs520