planner: DELETE cannot delete data in some cases when the database name is capitalized (#21202)
#21205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/execution
|
@winoros you're already a collaborator in bot's repo. |
winoros
reviewed
Nov 23, 2020
lzmhhh123
reviewed
Nov 23, 2020
eurekaka
reviewed
Nov 23, 2020
executor/delete_test.go
Outdated
| "github.com/pingcap/tidb/util/testkit" | ||
| ) | ||
|
|
||
| func (s *testSuite8) TestDeleteLockKey(c *C) { |
There was a problem hiding this comment.
@winoros this test is unexpected?
winoros
force-pushed
the
release-3.0-1cdc15baaa08
branch
from
d8ca695
to
aa4a650
Compare
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21202 to release-3.0
What problem does this PR solve?
Issue Number: close #21200
Problem Summary:
The
CurrentDBin session vars is stored the original string representation. (i.e. if we create the database name astEsT1, theCurrentDBwould betEsT1.However, in the codes that we changed in the pr, we treat the
CurrentDBas its lower representation. This leads to wrong string comparison result. SoDELETEmight not delete the data correctly.What is changed and how it works?
Proposal: xxx
What's Changed:
Wrap
CIStrupon theCurrentDB.Related changes
Check List
Tests
Release note
DELETEmay not delete data correctly when the database name is not in pure lower representation.