store/tikv: reduce BatchGet pending keys only when there is no response-level error #21157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sticnarf
added
status/WIP
type/bugfix
…se-level error Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
batch-get-async-commit
branch
from
2c6797d to
6e42b1a
Compare
…tidb into batch-get-async-commit
|
/run-all-tests tikv=pr/9077 |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
|
…ommit Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
MyonKeminta
previously approved these changes
Nov 25, 2020
store/mockstore/unistore/rpc.go
Outdated
| }, nil) | ||
| } | ||
| }) | ||
|
|
||
| resp.Resp, err = c.usSvr.KvBatchGet(ctx, req.BatchGet()) |
There was a problem hiding this comment.
Consider use batchGetReq instead of req.BatchGet() to make the purpose more clear. It doesn't matter though.
There was a problem hiding this comment.
Fixed. Could you approve the PR again?
ti-srebot
added
status/LGT2
ti-srebot
previously approved these changes
Nov 25, 2020
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
…tidb into batch-get-async-commit
MyonKeminta
approved these changes
Nov 26, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sticnarf merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: tikv/tikv#9069
What is changed and how it works?
If the response-level error exists, we don't read the
pairsand need to resend the original BatchGet request.Related changes
Check List
Tests
Release note