server: make dump binary time more compatible with MySQL (#21127) #21135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@jackysp you're already a collaborator in bot's repo. |
|
https://github.com/pingcap/tidb-test/pull/1108 related test. |
|
/run-all-tests tidb-test=pr/1108 |
|
LGTM |
|
LGTM |
ti-srebot
added
status/LGT2
|
/approve |
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
jackysp
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21127 to release-4.0
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Dumping binary time is not compatible with MySQL with short values, e.g. 2020-11-19. MySQL will only dump 4 bytes.
What is changed and how it works?
Proposal: xxx
What's Changed:
Adjust the length with the time value.
How it Works:
Related changes
Check List
Tests
https://github.com/pingcap/tidb-test/pull/1106
Release note