Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: should not skip when default value is not null (#20491) #20532

Merged
merged 4 commits into from
Oct 28, 2020
Merged

table: should not skip when default value is not null (#20491) #20532

merged 4 commits into from
Oct 28, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20491 to release-3.0

What problem does this PR solve?

Issue Number: close #20490

Problem Summary:

When new added column changed from not null to null, the default value may not correct.

Release note

@elvizlai @ti-srebot
cherry pick pingcap#20491 to release-3.0
10ddf37 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Oct 20, 2020
Merged
@ti-srebot ti-srebot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/sql-infra SIG: SQL Infra type/3.0-cherry-pick labels Oct 20, 2020
@ti-srebot ti-srebot added this to the 3.0.20 milestone Oct 20, 2020
tangenta
tangenta reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2020
AilinKid
AilinKid reviewed Oct 28, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2020
@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
update parser
05d74ec 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
Copy link
Contributor

/run-all-tests

@bb7133 bb7133 merged commit 87a2cf7 into pingcap:release-3.0 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@AilinKid AilinKid AilinKid approved these changes

Assignees

@tangenta tangenta

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.20
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @AilinKid @tangenta @bb7133 @elvizlai