Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix read failure from system tables `tiflash_segme ... (#19714) #19748

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19714 to release-4.0


What problem does this PR solve?

Issue Number: close #18701

Problem Summary: When some tiflash node is down, tidb will still try to fetch data from them and this makes the query failed.

What is changed and how it works?

What's Changed: Check whether tiflash http_port is open before fetch data from them.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

Release note

  • fix read failure from system tables tiflash_segments and tiflash_tables when some tiflash node is down

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
@lidezhu
Copy link
Contributor

lidezhu commented Sep 3, 2020

/run-all-tests

3 similar comments
@lidezhu
Copy link
Contributor

lidezhu commented Sep 3, 2020

/run-all-tests

@lidezhu
Copy link
Contributor

lidezhu commented Sep 3, 2020

/run-all-tests

@lidezhu
Copy link
Contributor

lidezhu commented Sep 3, 2020

/run-all-tests

@lidezhu
Copy link
Contributor

lidezhu commented Sep 4, 2020

/run-all-tests

1 similar comment
@lidezhu
Copy link
Contributor

lidezhu commented Sep 4, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 4, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 4, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason zz-jason changed the title fix read failure from system tables tiflash_segments and tiflash_tables when some tiflash node is down (#19714) fix read failure from system tables `tiflash_segme ... (#19714) Sep 4, 2020
@zz-jason zz-jason merged commit a5922c2 into pingcap:release-4.0 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants