Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: change dispatch failed log to info level (#19217) #19454

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19217 to release-4.0


Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: Part of #19053 (does not close issue)

Problem Summary:
Dispatching error is the error from the client, the server doesn't do anything wrong.

What is changed and how it works?

Proposal: xxx

What's Changed:
Change it to info level

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • Invalid SQL statements (dispatch errors) have been changed from an Error to an Info message in the server log file.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2020
@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Aug 28, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19445
  • 19518
  • 19452
  • 19439
  • 19465
  • 19628
  • 19611
  • 19577
  • 19559
  • 19614
  • 19546
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18696
  • 18760
  • 19215
  • 18801
  • 19445
  • 19452
  • 19439
  • 19465
  • 19611
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19611
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 18801
  • 19445
  • 19452
  • 19465
  • 19601
  • 19611
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19601
  • 18801
  • 18696
  • 18760
  • 19049
  • 19452

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 5eed05b into pingcap:release-4.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants