Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: add TiDB-Runtime dashboard (#19144) #19396

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 24, 2020

cherry-pick #19144 to release-4.0


What problem does this PR solve?

Add a new dashboard to show runtime related metrics.

Release note

  • Add TiDB-Runtime dashboard

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobotu please resolve conflicts.

@bobotu
Copy link
Contributor

bobotu commented Sep 2, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 2, 2020

Visit the grafana server at: http://172.16.5.5:32522, it will last for 5 hours

* grafana: add `TiDB-Runtime` dashboard

* address comments

* add live objects & refine title of gc count panel

* show instance selector

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@bobotu
Copy link
Contributor

bobotu commented Sep 2, 2020

PTAL @zz-jason @jackysp @lysu

@lysu
Copy link
Contributor

lysu commented Sep 3, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 3, 2020

@sre-bot
Copy link
Contributor

sre-bot commented Sep 3, 2020

Visit the grafana server at: http://172.16.5.5:32718, it will last for 5 hours

@lysu
Copy link
Contributor

lysu commented Sep 3, 2020

/rebuild

@lysu
Copy link
Contributor

lysu commented Sep 3, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 3, 2020
@zz-jason zz-jason merged commit 3d6935d into pingcap:release-4.0 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants