-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, tables: support the column type change between the integer types #19059
Conversation
2ab2169
to
b8e9862
Compare
b8e9862
to
d50e64e
Compare
Codecov Report
@@ Coverage Diff @@
## master #19059 +/- ##
================================================
+ Coverage 79.0884% 79.6347% +0.5462%
================================================
Files 549 549
Lines 149047 152068 +3021
================================================
+ Hits 117879 121099 +3220
+ Misses 21659 21514 -145
+ Partials 9509 9455 -54 |
a66812b
to
7bd7216
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
/run-check_dev_2 |
/run-unit-test |
The CI failure analysis: 1: problem occurs with 2: better put modification of the
Because once it errors in fail point, it will return without |
4bccdbc
to
ff55eb1
Compare
The failpoint is used for the test, so I think we needn't to do it. However, in order to get the test failure information more easily, I set the job state to |
/run-all-tests |
LGTM |
/run-all-tests |
@zimulala merge failed. |
What problem does this PR solve?
Issue Number: close #19118
Support the column type change between the integer types(no rollback operation is supported yet).
Related PR: pingcap/parser#966
What is changed and how it works?
Proposal: #18435
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note