tikv: fix "Got too many pings" GRPC error in PD-se ... (#17885) #17944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/tikv
type/3.0-cherry-pick
type/bugfix
qw4990
added
status/LGT2
|
Sorry @qw4990, you don't have permission to trigger auto merge event on this branch. |
zz-jason
changed the title
kennytm
reviewed
Jun 30, 2020
| @@ -56,7 +56,6 @@ func createEtcdKV(addrs []string, tlsConfig *tls.Config) (*clientv3.Client, erro | |||
| Endpoints: addrs, | |||
| AutoSyncInterval: 30 * time.Second, | |||
| DialTimeout: 5 * time.Second, | |||
| TLS: tlsConfig, | |||
There was a problem hiding this comment.
I think this is an accident...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17885 to release-3.0
What problem does this PR solve?
Issue Number: close #17870
Problem Summary:
In PD(etcd) server side,
PermitWithoutStreamvalues isfalsehttps://github.com/etcd-io/etcd/blob/master/embed/etcd.go#L641, meansbut in TiDB client side,
PermitWithoutStreamvalues istruemeansso, with those conflict configuration, grpc server side will count pingStrike with wrong value.
https://github.com/grpc/grpc-go/blob/master/internal/transport/http2_server.go#L711
and report "transport: Got too many pings from the client, closing the connection." error.
What is changed and how it works?
What's Changed, How it Works:
we need keep them both as true or false, but etcd write it with magic value(false)
so we only can change tidb-side to false
Related changes
Check List
Tests
Side effects
Release note
This change is