ddl: fix creating partition table with unique prefix index #17196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
reviewed
May 14, 2020
ddl/partition.go
Outdated
| @@ -761,6 +763,15 @@ func checkPartitioningKeysConstraints(sctx sessionctx.Context, s *ast.CreateTabl | |||
| return nil | |||
| } | |||
|
|
|||
| func hasPrefixIndexColumn(idxCols []*model.IndexColumn) bool { | |||
| for _, col := range idxCols { | |||
| if col.Length > 0 { | |||
There was a problem hiding this comment.
Should check the table name too?
Below sql will execute sucessfull in Mysql but faild in This PR:
create table part12 (a varchar(20), b varchar(10), unique index (a(5),b)) partition by range columns (b) (
partition p0 values less than ('aaaaa'),
partition p1 values less than ('bbbbb'),
partition p2 values less than ('ccccc'))
Codecov Report
@@ Coverage Diff @@
## master #17196 +/- ##
===========================================
Coverage 80.1515% 80.1515%
===========================================
Files 511 511
Lines 140137 140137
===========================================
Hits 112322 112322
Misses 18855 18855
Partials 8960 8960 |
tiancaiamao
force-pushed
the
prefix-index-partition
branch
from
a3571a0
to
b0fcc28
Compare
tiancaiamao
added
the
priority/release-blocker
|
/run-all-tests |
bb7133
approved these changes
May 14, 2020
|
cherry pick to release-4.0 in PR #17213 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 14, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17214 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 14, 2020
|
cherry pick to release-3.1 in PR #17215 |
jebter
added a commit
that referenced
this pull request
May 21, 2020
bb7133
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
MySQL: A UNIQUE INDEX must include all columns in the table's partitioning function
TiDB: no error
Problem Summary:
Unique prefix index can't be used on the partition table.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Add check
Related changes
Check List
Tests
Release note