Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incorrect result of logical operators for vectorized expression evaluation #15891

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Mar 31, 2020

What problem does this PR solve?

Related to: #PR12173 #issue15718

What is changed and how it works?

Apply changes from #PR12173 to vectorized expression evaluation.
Fix the wrong bitwise operations.

Check List

Tests

  • Unit test

@Reminiscent Reminiscent requested a review from a team as a code owner March 31, 2020 06:46
@ghost ghost removed their request for review March 31, 2020 06:46
@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #15891 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15891   +/-   ##
===========================================
  Coverage   80.5687%   80.5687%           
===========================================
  Files           505        505           
  Lines        135467     135467           
===========================================
  Hits         109144     109144           
  Misses        17845      17845           
  Partials       8478       8478           

@github-actions github-actions bot added the sig/execution SIG execution label Mar 31, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

@Reminiscent merge failed.

@Reminiscent
Copy link
Contributor Author

/run-unit-test

@Reminiscent
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

@Reminiscent merge failed.

@Reminiscent
Copy link
Contributor Author

/run-integration-common-test

@Reminiscent
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 31, 2020

cherry pick to release-4.0 in PR #15907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants