*: read committed transaction gets a wrong snapshot with subquery #15471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #15471 +/- ##
===========================================
Coverage ? 80.3791%
===========================================
Files ? 502
Lines ? 133832
Branches ? 0
===========================================
Hits ? 107573
Misses ? 17814
Partials ? 8445 |
|
LGTM |
1 similar comment
|
LGTM |
coocood
approved these changes
Mar 19, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
The early executed subquery consume the statement tso request and abandoned the executor after it executed, which makes the statement can not get the new tso instead of using the transaction start tso to read data.
What is changed and how it works?
Make
refreshForUpdateTSForRCassign a new snapshot tso no matter the statement tso request is nil or not.Check List
Tests