expression: fix wrong behavior for IF(not_int, *, *) (#15016) #15356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/expression
contribution
|
/run-all-tests |
|
/run-unit-test |
|
@SunRunAway, @qw4990, PTAL. |
zz-jason
added
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 15, 2020
|
cherry pick to release-3.1 in PR #16424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15016 to release-3.0
What problem does this PR solve?
fix #11601
What is changed and how it works?
original issue was cause by using
types.ETIntfor arg0 rounding float to int. This PR usingwrapWithIsTrueofisTrueOrFalseFunctionClassto handle different types correctly convert to int.Check List
Tests
Code changes
Side effects
Related changes
Release note