infoschema: remove the inspection_schema #15296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
github-actions
bot
added
sig/sql-infra
Signed-off-by: Lonng <heng@lonng.org>
Codecov Report
@@ Coverage Diff @@
## master #15296 +/- ##
==============================================
- Coverage 80.3483% 80.3284% -0.02%
==============================================
Files 503 502 -1
Lines 133144 133121 -23
==============================================
- Hits 106979 106934 -45
- Misses 17740 17759 +19
- Partials 8425 8428 +3 |
|
/run-all-tests tidb-test=pr/1001 |
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
|
Great！LGTM |
|
/rebuild |
|
/run-all-tests tidb-test=pr/1001 |
reafans
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
This PR removes the
inspection_schemaand implements the inspection cache table ininformation_schamedirectly. It's a mistake of introducing theinspection_schemaand we have found another to correct it in time.What is changed and how it works?
Will return the cached rows if the SQL in inspection mode.
Check List
Tests
Release note