Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix a bug that the pessimistic lock doesn't work on a partition (#14921) #15114

Merged
merged 4 commits into from
Mar 9, 2020

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #14921

Resolve conflict because the tblID2Handle is in the Schame() in 3.0 branch

…ingcap#14921)

physicalID should be used if 'select for update' works on a
partitioned table.
@tiancaiamao tiancaiamao added type/3.0-cherry-pick type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Mar 4, 2020
@tiancaiamao
Copy link
Contributor Author

CI failure is not caused by this change.
Issue here #15118

PTAL @coocood @winoros

@coocood
Copy link
Member

coocood commented Mar 4, 2020

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

PTAL @winoros

@tiancaiamao tiancaiamao requested a review from winoros March 6, 2020 12:25
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 7, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2020

@tiancaiamao merge failed.

@tiancaiamao
Copy link
Contributor Author

/rebuild

@jackysp
Copy link
Member

jackysp commented Mar 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit bd70523 into pingcap:release-3.0 Mar 9, 2020
@tiancaiamao tiancaiamao deleted the cherry-14921 branch March 9, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants