Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add counter for keys locking numbers(#14625) #14634

Merged
merged 2 commits into from
Feb 5, 2020
Merged

server: add counter for keys locking numbers(#14625) #14634

merged 2 commits into from
Feb 5, 2020

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Feb 5, 2020

What problem does this PR solve?

Cherry-pick #14625 to release-3.0

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to update the tidb-ansible repository

Release note

Deardrops
Deardrops reviewed Feb 5, 2020
View reviewed changes
Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk cfzjywxk mentioned this pull request Feb 5, 2020
Merged
@Deardrops Deardrops added status/LGT1 Indicates that a PR has LGTM 1. component/server labels Feb 5, 2020
jackysp
jackysp approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

Your auto merge job has been accepted, waiting for 14620, 14518

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

/run-all-tests

@sre-bot sre-bot merged commit ce94978 into pingcap:release-3.0 Feb 5, 2020
@cfzjywxk cfzjywxk changed the title server: add lock keys counter metric server: add counter for keys locking numbers(#14625) Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deardrops Deardrops Deardrops left review comments

@jackysp jackysp jackysp approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/server status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cfzjywxk @sre-bot @jackysp @Deardrops @zz-jason