Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, stats: handle add/trunctate partition events (#14500) #14566

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 22, 2020

cherry-pick #14500 to release-3.0


What problem does this PR solve?

When add or truncate paritions, stats is not automatically updated.

What is changed and how it works?

Handle ddl events for add or truncate partitions in stats.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Create new stats for add partition or truncate partition to fix the issue that when adding or truncating partitions, stats are not automatically updated.

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 22, 2020

/run-all-tests

@bb7133 bb7133 added this to the v3.0.10 milestone Jan 22, 2020
@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 22, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 23, 2020
@zz-jason zz-jason merged commit e853ebd into pingcap:release-3.0 Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants