Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: enhance rule partition pruning (#14544) #14546

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #14544

What problem does this PR solve?

fix #14539

What is changed and how it works?

Use ranger.DetachCondAndBuildRangeForIndex instead of ranger.ExtractAccessConditionsForColumn in partitionProcessor.canBePruned.
Because of that ExtractAccessConditionsForColumn only handles the scenario that the CNF/DNF only covers one column.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

release-3.0

Release note

Enhance the logical rule partition pruning to cover more scenarios.

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Jan 20, 2020
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2020

Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch.

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason merged commit 8286441 into pingcap:release-3.0 Jan 20, 2020
@XuHuaiyu XuHuaiyu deleted the release-3.0 branch January 20, 2020 07:31
@bb7133 bb7133 added this to the v3.0.10 milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants