Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema, util: add table events_statements_summary_by_digest_history (#13813) #14166

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

djshow832
Copy link
Contributor

conflicting files:
config_test.go
const.go
global_vars_cache.go
set.go
statement_summary.go
sysvar.go
tables.go
tables_test.go
tidb_vars.go
varsutil.go

What problem does this PR solve?

Add a history table for statement summary for storing summaries that expired from events_statements_summary_by_digest.

What is changed and how it works?

Add a virtual table events_statements_summary_by_digest_history. When a summary expires from events_statements_summary_by_digest, put it into events_statements_summary_by_digest_history.
There's a system variable tidb_stmt_summary_history_size to control the history size for each summary.

Check List

Tests

  • Unit test
  • Manual test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Add a history table events_statements_summary_by_digest_history to store history summaries of events_statements_summary_by_digest.

@djshow832 djshow832 added priority/release-blocker This issue blocks a release. Please solve it ASAP. type/usability type/3.0 cherry-pick labels Dec 20, 2019
@djshow832
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 45c52c4 into pingcap:release-3.0 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants