expression: fix invalid compare-operations in vectorized builtinInDecimalSig
#14156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
|
/run-all-tests |
|
/run-all-tests |
lonng
reviewed
Dec 20, 2019
| @@ -188,7 +188,7 @@ func (b *builtinInDecimalSig) vecEvalInt(input *chunk.Chunk, result *chunk.Colum | |||
| arg0 := args0[i] | |||
| arg1 := args1[i] | |||
| compareResult = 1 | |||
There was a problem hiding this comment.
Seems we don't need this variable?
There was a problem hiding this comment.
This logic is generated from our template and this variable makes it easier for us to write template code.
breezewish
approved these changes
Dec 20, 2019
|
LGTM |
qw4990
added
status/all tests passed
status/LGT2
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When comparing two decimals, we should use
MyDecimal.Compareinstead of using==.Check List
Tests