Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinExtractDurationSig #14139

Closed
wants to merge 1 commit into from
Closed

expression: implement vectorized evaluation for builtinExtractDurationSig #14139

wants to merge 1 commit into from

Conversation

BaoWentz
Copy link

What problem does this PR solve?

expression: implemented vectorized “builtinExtractDurationSig”

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFuncGenerated-8           1000000000               0.0997 ns/op          0 B/op          0 allocs/op

BenchmarkVectorizedBuiltinTimeFunc-8                    1000000000               0.0219 ns/op          0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@BaoWentz BaoWentz requested a review from a team as a code owner December 19, 2019 07:01
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 19, 2019
@claassistantio
Copy link

claassistantio commented Dec 19, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team December 19, 2019 07:02
@qw4990 qw4990 changed the title expression: implemented vectorized “builtinExtractDurationSig” expression: implement vectorized evaluation for builtinExtractDurationSig Dec 19, 2019
@qw4990
Copy link
Contributor

qw4990 commented Dec 20, 2019

Hi, @BaoWentz , I'm sorry to tell you that this builtinFunction has been vectorized by #13489.
Could you please choose another builtin-function to vectorize?

@francis0407 francis0407 added the duplicate Issues or pull requests already exists. label Dec 24, 2019
@wshwsh12 wshwsh12 removed their request for review December 26, 2019 14:01
@XuHuaiyu XuHuaiyu removed their request for review January 2, 2020 03:16
@qw4990
Copy link
Contributor

qw4990 commented Jan 20, 2020

Hi, @BaoWentz , I'm sorry to tell you that this builtinFunction has been vectorized by #13489.
Could you please choose another builtin-function to vectorize?

Close due to this reason.

@qw4990 qw4990 closed this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. duplicate Issues or pull requests already exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BaoWentz @claassistantio @qw4990 @francis0407 @sre-bot