Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo, planner: fix sql bind when sql has symbol list (#13889) #14004

Merged
merged 6 commits into from
Dec 13, 2019
Merged

bindinfo, planner: fix sql bind when sql has symbol list (#13889) #14004

merged 6 commits into from
Dec 13, 2019

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Dec 10, 2019 •
edited
Loading

cherry pick #13889

What problem does this PR solve?

Fix #13871, related PR pingcap/parser#656

What is changed and how it works?

Introduce parser.DigestNormalized to avoiding twice normalized.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • fix that SQL bind cannot be hit when a SQL has symbol list

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway SunRunAway added type/3.0 cherry-pick sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Dec 11, 2019
@SunRunAway
Copy link
Contributor Author

/run-all-tests

@SunRunAway SunRunAway added this to the v3.0.7 milestone Dec 11, 2019
alivxxx
alivxxx reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

winoros
winoros previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SunRunAway
Copy link
Contributor Author

@zz-jason @eurekaka Please help merge.

zz-jason
zz-jason reviewed Dec 12, 2019
View reviewed changes
bindinfo/handle.go Outdated Show resolved Hide resolved
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Dec 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 12, 2019

/run-all-tests

@eurekaka
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit be7cb4d into pingcap:release-3.0 Dec 13, 2019
@SunRunAway SunRunAway deleted the cherrypick-13889 branch December 13, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx left review comments

@eurekaka eurekaka eurekaka approved these changes

@winoros winoros winoros left review comments

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SunRunAway @sre-bot @eurekaka @zz-jason @winoros @alivxxx