Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastStringAsRealSig #13969

Merged
merged 3 commits into from
Dec 19, 2019
Merged

expression: implement vectorized evaluation for builtinCastStringAsRealSig #13969

merged 3 commits into from
Dec 19, 2019

Conversation

eggeek
Copy link
Contributor

@eggeek eggeek commented Dec 8, 2019

PCP #12105

What problem does this PR solve?

  1. Add vectorized expression: builtinCastStringAsRealSig
  2. Add the corresponding test case
  3. Add the corresponding generator: realStringGener

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsRealSig-VecBuiltinFunc-8             10000            102142 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsRealSig-NonVecBuiltinFunc-8           8454            132102 ns/op               0 B/op          0 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      2.785s

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has interface methods change

Release note

  • No

@eggeek eggeek requested a review from a team as a code owner December 8, 2019 11:01
@sre-bot
Copy link
Contributor

sre-bot commented Dec 8, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 8, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 8, 2019 11:01
@codecov
Copy link

codecov bot commented Dec 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@39a370c). Click here to learn what that means.
The diff coverage is 62.9629%.

@@             Coverage Diff             @@
##             master     #13969   +/-   ##
===========================================
  Coverage          ?   80.1623%           
===========================================
  Files             ?        480           
  Lines             ?     120251           
  Branches          ?          0           
===========================================
  Hits              ?      96396           
  Misses            ?      16162           
  Partials          ?       7693

qw4990
qw4990 reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 10, 2019
zz-jason
zz-jason approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

Your auto merge job has been accepted, waiting for 14052, 14132, 14106, 14134, 13249

@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

@eggeek merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Dec 19, 2019

/run-all-tests

@qw4990 qw4990 changed the title expression: implement vectorized for builtinCastStringAsRealSig expression: implement vectorized evaluation for builtinCastStringAsRealSig Dec 19, 2019
@qw4990 qw4990 merged commit eef8c39 into pingcap:master Dec 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

@eggeek complete task #12105 and get 50 score, currerent score 50.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@eggeek @XiaTianliang
expression: implement vectorized for builtinCastStringAsRealSig (pi…
fc27501 
…ngcap#13969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eggeek @sre-bot @qw4990 @zz-jason @wshwsh12