Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add configuration entry make TiDB version string configurable (#13775) #13906

Merged
merged 8 commits into from
Dec 5, 2019
Merged

Conversation

reafans
Copy link
Contributor

@reafans reafans commented Dec 4, 2019

What problem does this PR solve?

cherry-pick #13775 to release-3.0

It can improve the hard-coding of serverVersion property.

What is changed and how it works?

add the serverVersion in config/config.go and config/config.toml.example

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Release note

@reafans reafans closed this Dec 5, 2019
@reafans reafans deleted the release-3.0 branch December 5, 2019 02:00
@reafans reafans restored the release-3.0 branch December 5, 2019 02:16
@reafans reafans reopened this Dec 5, 2019
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reafans reafans added status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Dec 5, 2019
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@djshow832 djshow832 added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 5, 2019
@reafans reafans added status/can-merge Indicates a PR has been approved by a committer. type/3.0 cherry-pick and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

Sorry @reafans, you don't have permission to trigger auto merge event on this branch.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Dec 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

Sorry @AilinKid, you don't have permission to trigger auto merge event on this branch.

@bb7133
Copy link
Member

bb7133 commented Dec 5, 2019

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Dec 5, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit b6a30b8 into pingcap:release-3.0 Dec 5, 2019
@reafans reafans deleted the release-3.0 branch December 13, 2019 06:56
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants