ddl: fix index length calculation (#13727) #13779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
bb7133
reviewed
Nov 27, 2019
|
please fix common-test |
AilinKid
added
status/LGT2
|
/run-common-test -tidb-test=pr/958 |
ngaut
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
failed. |
|
/run-common-test -tidb-test=pr/958 |
|
Please resolve the conflicts @tangenta |
1 similar comment
|
Please resolve the conflicts @tangenta |
tangenta
force-pushed
the
release-3.0-755fd1924b78
branch
from
42a2631
to
a1a4ffd
Compare
|
This PR should be merge together with pingcap/tidb-test#958 |
|
/run-common-test -tidb-test=pr/958 |
|
/merge |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-common-test -tidb-test=pr/958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #13727 to release-3.0
What problem does this PR solve?
In MySQL 8.0:
In TiDB master:
The default charset is
utf8mb4with at most 4 bytes per character. However, TiDB assumes 1 byte per character by default, which is incorrect.What is changed and how it works?
getIndexColumnLength, taking charsets into consideration.Check List
Tests
Code changes
N/A
Side effects
Related changes
Release note