Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove unused code #13674

Merged
merged 6 commits into from
Nov 22, 2019
Merged

*: Remove unused code #13674

merged 6 commits into from
Nov 22, 2019

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Nov 21, 2019 •
edited
Loading

What problem does this PR solve?

Tidy Code

What is changed and how it works?

Removed unused code

Check List

Tests

  • Unit test
  • Integration test

This change is Reviewable

@xiekeyi98 xiekeyi98 requested a review from a team as a code owner November 21, 2019 15:33
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 21, 2019
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team November 21, 2019 15:33
@codecov
Copy link

codecov bot commented Nov 21, 2019 •
edited
Loading

Codecov Report

Merging #13674 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13674   +/-   ##
===========================================
  Coverage   80.2163%   80.2163%           
===========================================
  Files           473        473           
  Lines        117845     117845           
===========================================
  Hits          94531      94531           
  Misses        15938      15938           
  Partials       7376       7376

zimulala
zimulala reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2019
jackysp
jackysp approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

Your auto merge job has been accepted, waiting for 13678

@jackysp
Copy link
Member

jackysp commented Nov 22, 2019

Hi @xiekeyi98 , please sign the CLA.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

/run-all-tests

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2019
@sre-bot sre-bot merged commit 4b830aa into pingcap:master Nov 22, 2019
@xiekeyi98 xiekeyi98 deleted the removeCode branch November 22, 2019 03:55
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@xiekeyi98 @XiaTianliang
*: Remove unused code (pingcap#13674)
a5c8d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@jackysp jackysp jackysp approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiekeyi98 @sre-bot @jackysp @zimulala @zz-jason