Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression : fix bug in insert select union select. (#13632) #13645

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Nov 21, 2019

What problem does this PR solve?

cherry-pick #13632 to release-2.1

conflict file:

insert_test.go

What is changed and how it works?

This problem comes from jsonUnquoteFunction function.
We should fill the Flen in jsonUnquoteFunctionClass.getFunction().
Cause return type string is an element set (maybe autowrapped as an array) of whole json, so here we set the flen with mysql.MaxFieldVarCharLength.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix bug in insert select union select, result from jsonUnquote function's flen.

Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@Deardrops
Copy link
Contributor

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

Your auto merge job has been accepted, waiting for 13651

@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

@AilinKid merge failed.

@Deardrops
Copy link
Contributor

/run-unit-test

@bb7133 bb7133 merged commit 630845b into pingcap:release-2.1 Nov 22, 2019
@bb7133 bb7133 added this to the v2.1.19 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants